Skip to content

std: Update std::task docs to reflect modern times #15047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2014

Conversation

brson
Copy link
Contributor

@brson brson commented Jun 19, 2014

This corrects some misinformation.

//! not to child). Failure propagation is instead handled as part of task
//! synchronization. For example, the channel `send()` and `recv()` methods will
//! fail if the other end has hung up already.
//! Tasks have their memory *isolated* from each other by virtue of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explicitly mention shared memory via Arc? (There's occasionally people stating "rust has no shared memory", which would be nice to squash (or replace with "rust has safe shared memory").)

(This also makes this isolation statement a bit of a lie.)

This corrects some misinformation.
@brson
Copy link
Contributor Author

brson commented Jun 20, 2014

@huonw Updated.

//! synchronization](../../std/sync/index.html) are often employed to
//! achieve particular performance goals. In particular, types that
//! are guaranteed to be threadsafe are easily shared between threads
//! using the atomically-reference-counted container,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/container/pointer/?

(r=me with or without this, at your discretion.)

bors added a commit that referenced this pull request Jun 20, 2014
This corrects some misinformation.
@bors bors closed this Jun 20, 2014
@bors bors merged commit cb89880 into rust-lang:master Jun 20, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 19, 2023
internal: Record file dependencies in crate graph construction

Should fix the bug mentioned in rust-lang/rust-analyzer#8623 where removing a crate root file will panic. I'm not too happy with the way this is done here but I can't think of a better way right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants