Skip to content

don't leave files that will not checksum if download is interrupted #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2012
Merged

don't leave files that will not checksum if download is interrupted #1548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/etc/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,13 @@ def local_rev_committer_date():
return local_rev_info("ci")

def get_url_to_file(u,f):
subprocess.check_call(["curl", "-o", f, u])
tmpf = f + '.tmp' # no security issue, just to stop partial download leaving a stale file
try:
subprocess.check_call(["curl", "-o", tmpf, u])
except subprocess.CalledProcessError:
os.unlink(tmpf)
raise
os.rename(tmpf, f)

def snap_filename_hash_part(snap):
match = re.match(r".*([a-fA-F\d]{40}).tar.bz2$", snap)
Expand Down