webfonts: name fix #15602
Merged
webfonts: name fix #15602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -478,8 +478,8 @@ fn write_shared(cx: &Context, | |||
| include_bin!("static/FiraSans-Regular.woff"))); | |||
| try!(write(cx.dst.join("FiraSans-Medium.woff"), | |||
| include_bin!("static/FiraSans-Medium.woff"))); | |||
| try!(write(cx.dst.join("SourceSerifPro-Bold.woff"), | |||
| include_bin!("static/SourceSerifPro-Bold.woff"))); | |||
| try!(write(cx.dst.join("SourceSerifPro-Regular.woff"), | |||
There was a problem hiding this comment.
Could you swap this with the Hueristica-Italic line, to keep it with the other SourceSerifPro?
|
@huonw Done. |
|
Well... I was actually thinking of moving it down, so that the 4 Source*Pro fonts are next to each other. (Sorry for nitpicking, but hopefully having the similar names adjacent will avoid mistakes like this in future.) |
|
@huonw Done. |
bors
added a commit
that referenced
this pull request
Jul 12, 2014
Not sure how I did miss that in the first place... r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how I did miss that in the first place...
r? @alexcrichton