rustdoc: render 1-tuples as (T,) instead of (T) #15614
Conversation
| format!("({:#})", typs).as_slice()) | ||
| match typs.as_slice() { | ||
| [ref one] => format!("({},)", one), | ||
| [..many] => format!("({:#})", many) |
There was a problem hiding this comment.
Why does this use {:#}? The documentation claims that the # flag only applies to integral formatting.
Also, [..many] is unnecessary, you can just say many.
There was a problem hiding this comment.
Ah hah, the documentation is wrong. # on slices omits the brackets. That really should be documented.
|
r=me if you tweak the |
|
@kballard thanks for the feedback. You are right the [..many] is unnecessary i will change that first. |
|
It occurs to me that I have no idea if rustdoc has an infrastructure for testing this sort of thing. If it does, it would be a good idea to add a test. |
|
@kballard i couldn't find any tests related to that. Do you think this kind of test should be added? |
|
Sadly we don't have a whole lot of tests for rustdoc right now, it's ok to add this without a test. |
This fixes #15474