libgetopts: doc fix. #16226
Closed
libgetopts: doc fix. #16226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,7 +128,7 @@ pub enum Occur { | |||
| Req, | |||
| /// The option could or not occur. | |||
There was a problem hiding this comment.
While you're at it, you could update this one to be more consistent.
/// The option occurs zero or one times.
|
Messed up the PR... doing a new one with a single commit. |
|
You can just force push, rather than opening a new pull request. |
|
Oh. Didn't think of that :-( will do next time. Sorry about that. |
|
It's all good! I say it purely for informational purposes :) |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 3, 2024
internal: Expose whether a channel has been dropped in lsp-server errors Not the best way to expose this, but this should allow us to give somewhat better errors when the initialization request is malformed, as currently that just results in a channel disconnected error instead of the deserialization error. cc rust-lang/rust-analyzer#15859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This confused me.
Seems like the Occur Multi enum allows the option to not appear at all, contrary to what the docs say.