Skip to content

Log linker stderr and stdout. #16694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2014
Merged

Log linker stderr and stdout. #16694

merged 1 commit into from
Aug 25, 2014

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Aug 23, 2014

Shows linker spew even when linking succeeds. This is occasionally useful in order to see verbose linker output.

@alexcrichton
Copy link
Member

Can you expand the commit message to be a little more descriptive than "debug-linker"?

@@ -1305,6 +1305,9 @@ fn link_natively(sess: &Session, trans: &CrateTranslation, dylib: bool,
sess.note(str::from_utf8(output.as_slice()).unwrap());
sess.abort_if_errors();
}
else if (sess.opts.debugging_opts & config::DEBUG_LINKER) != 0 { // show linker output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our current style is to put the else on the same line as the previous }

@alexcrichton
Copy link
Member

Another possible option would be to just put this in a call to info! rather than making it a full-fledged compiler flag.

@vadimcn vadimcn changed the title Add -Z debug-linker Log linker stderr and stdout. Aug 23, 2014
@vadimcn
Copy link
Contributor Author

vadimcn commented Aug 23, 2014

ok, info! is fine by me.

@vadimcn
Copy link
Contributor Author

vadimcn commented Aug 23, 2014

Actually, let's make it a debug!,- for consistency with logging of the linker command line.

bors added a commit that referenced this pull request Aug 25, 2014
Shows linker spew even when linking succeeds.  This is occasionally useful in order to see verbose linker output.
@bors bors closed this Aug 25, 2014
@bors bors merged commit 77e39b0 into rust-lang:master Aug 25, 2014
@vadimcn vadimcn deleted the debug-linker branch March 1, 2015 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants