Center alignment for fmt #16885
Merged
Center alignment for fmt #16885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python uses |
|
Good point, I wasn't aware of the python heritage. Changed it to '^' |
| rt::AlignLeft => ( 0u, padding ), | ||
| rt::AlignRight | rt::AlignUnknown => ( padding, 0u ), | ||
| rt::AlignCenter => ( padding / 2, ( padding + 1 ) / 2 ), | ||
| }; |
There was a problem hiding this comment.
Stylistically we normally don't put spaces around the parens in tuples
|
This looks like a solid implementation @wickerwaka, thanks! @P1start is right in that the design was influenced by python, so I think it makes sense to go ahead and implement this as well. |
|
The module docs should be updated as well: http://doc.rust-lang.org/std/fmt/#fill/alignment |
Use '^' to specify center alignment in format strings.
fmt!( "[{:^5s}]", "Hi" ) -> "[ Hi ]"
fmt!( "[{:^5s}]", "H" ) -> "[ H ]"
fmt!( "[{:^5d}]", 1i ) -> "[ 1 ]"
fmt!( "[{:^5d}]", -1i ) -> "[ -1 ]"
fmt!( "[{:^6d}]", 1i ) -> "[ 1 ]"
fmt!( "[{:^6d}]", -1i ) -> "[ -1 ]"
If the padding is odd then the padding on the right will be one
character longer than the padding on the left.
Tuples squashed
wickerwaka
force-pushed
the
fmt-center
branch
from
cb6fff1 to
2bc4a5e
Compare
bors
added a commit
that referenced
this pull request
Sep 4, 2014
Use '^' to specify center alignment in format strings.
```
fmt!( "[{:^5s}]", "Hi" ) -> "[ Hi ]"
fmt!( "[{:^5s}]", "H" ) -> "[ H ]"
fmt!( "[{:^5d}]", 1i ) -> "[ 1 ]"
fmt!( "[{:^5d}]", -1i ) -> "[ -1 ]"
fmt!( "[{:^6d}]", 1i ) -> "[ 1 ]"
fmt!( "[{:^6d}]", -1i ) -> "[ -1 ]"
```
If the padding is odd then the padding on the right will be one
character longer than the padding on the left.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
fix: Improve error recovery for match arms This should make use of the recovery token sets, but I think it'd be better to fix that as a whole while fixing the other places for these adhoc recovery checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use '^' to specify center alignment in format strings.
If the padding is odd then the padding on the right will be one
character longer than the padding on the left.