test: Tweak tcp-accept-stress one last time #16916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tcp-accept-stress, despite the previous modifications, is still deadlocking on the osx buildbots. When building/testing/running repeatedly locally, it was discovered that the test would often fail with TcpStream::connect returning the error `address not available`. This test opens up quite a large number of sockets, and it looks like by default osx isn't the speediest at recycling those sockets for further use. The test has been modified (and verified) to not deadlock in this error case, and the test is not just officially ignored on OSX (with no FIXME). I believe that we'll get good coverage of the relevant code on the linux builders, so this isn't so much of a loss. At the same time I turned down the stress parameters to hopefully lighten the socket load on other platforms.
|
Well, one last time, hopefully. |
bors
added a commit
that referenced
this pull request
Sep 2, 2014
…y, r=brson The tcp-accept-stress, despite the previous modifications, is still deadlocking on the osx buildbots. When building/testing/running repeatedly locally, it was discovered that the test would often fail with TcpStream::connect returning the error `address not available`. This test opens up quite a large number of sockets, and it looks like by default osx isn't the speediest at recycling those sockets for further use. The test has been modified (and verified) to not deadlock in this error case, and the test is not just officially ignored on OSX (with no FIXME). I believe that we'll get good coverage of the relevant code on the linux builders, so this isn't so much of a loss. At the same time I turned down the stress parameters to hopefully lighten the socket load on other platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tcp-accept-stress, despite the previous modifications, is still deadlocking
on the osx buildbots. When building/testing/running repeatedly locally, it was
discovered that the test would often fail with TcpStream::connect returning the
error
address not available.This test opens up quite a large number of sockets, and it looks like by default
osx isn't the speediest at recycling those sockets for further use.
The test has been modified (and verified) to not deadlock in this error case,
and the test is not just officially ignored on OSX (with no FIXME). I believe
that we'll get good coverage of the relevant code on the linux builders, so this
isn't so much of a loss.
At the same time I turned down the stress parameters to hopefully lighten the
socket load on other platforms.