librustc: Parse and resolve higher-rank lifetimes in traits. #17028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pnkfelix Perhaps you can review? |
| ast::ItemTrait(ref generics, _, _, _) => { | ||
| let scope: ScopeChain = | ||
| EarlyScope(subst::TypeSpace, &generics.lifetimes, &root); | ||
| self.check_lifetime_defs(&generics.lifetimes, &scope); | ||
| scope | ||
| } | ||
| ast::ItemImpl(ref generics, _, _, _) => { |
There was a problem hiding this comment.
did this need to get split off into its own clause? Or was this change an artifact of earlier code instrumentation that you since removed?
|
looks good to me; r=me with nits above addressed. |
pcwalton
force-pushed
the
higher-rank-trait-lifetimes
branch
from
c260ac6 to
533feba
Compare
They will ICE during typechecking if used, because they depend on trait reform. This is part of unboxed closures.
pcwalton
force-pushed
the
higher-rank-trait-lifetimes
branch
from
533feba to
5376b1c
Compare
bors
added a commit
that referenced
this pull request
Sep 23, 2014
…nkfelix They will ICE during typechecking if used, because they depend on trait reform. This is part of unboxed closures. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They will ICE during typechecking if used, because they depend on trait
reform.
This is part of unboxed closures.
r? @nikomatsakis