Add note about overriding the standard library #17400
Conversation
This one threw me for a loop while following the guide and trying to learn the language.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. |
|
Thanks! This looks fine to me, but I'd like @steveklabnik to weigh in as well before merging it. |
|
no clue why this would have caused a build error... it is just documentation |
|
Don't worry about the build error, it's not a big deal. I'm curious, since I already mention this is provided by Rust, maybe this paragraph should go with that sentence, above? Also, we try not to use 'here' for link text. |
|
This has been sitting idle for a while. @ericfrederich, can you respond to @steveklabnik's questions? |
|
Closing for now due to inactivity, but feel free to open with a rebase and response to @steveklabnik's concerns. |
feat: add bool_to_enum assist for parameters
## Summary
This PR adds parameter support for `bool_to_enum` assists. Essentially, the assist can now transform this:
```rs
fn function($0foo: bool) {
if foo {
println!("foo");
}
}
```
To this,
```rs
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn function(foo: Bool) {
if foo == Bool::True {
println!("foo");
}
}
```
Thanks to `@/davidbarsky` for the test skeleton (:
Closes rust-lang#17400
This one threw me for a loop while following the guide and trying to learn the language.