Skip to content

fix build errors on FreeBSD #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix build errors on FreeBSD #1791

wants to merge 1 commit into from

Conversation

crabtw
Copy link
Contributor

@crabtw crabtw commented Feb 9, 2012

  • freebsd has no execvpe function, so I set the environ variable and call execvp instead.
  • There is a weird problem that clang can not find INTPTR_MAX.
    Although __STDC_LIMIT_MACROS is defined, I have to redefine it in rust_kernel.cpp.
  • Declarations of rust_scheduler in rust_kernel.cpp and rust_scheduler.h are different, so I change struct to class.
  • libuv has different configs on unix platforms.
    In order to make them distinguishable, I move the makefiles of linux platform to unix/linux and move makefiles of freebsd to unix/freebsd.

@brson brson mentioned this pull request Feb 9, 2012
Closed
@brson
Copy link
Contributor

brson commented Feb 10, 2012

Merged.

@brson brson closed this Feb 10, 2012
celinval added a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
@celinval
Disable debug_asserts inside std due to poor UX (rust-lang#1791)
1744591 
This is a possible workaround for now to improve the UX around UB
detection in intrinsics when using the MIR Linker. The issue is tracked
here:
model-checking/kani#1740

Basically, the rust toolchain uses a release build that removes all
debug assertions from the standard library. When we switched to using
our custom build of the `std` we decided to enable the debug assertions
in order to catch more potential UBs. However, the UX is not always
great. The assertions don't have any clear descriptions and they may
fail in unexpected places. E.g.: The violation of an intrinsic safety
condition triggers the following failures:
```
> Failed checks: Called `Option::unwrap()` on a `None` value
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crabtw @brson