Skip to content

Fix HTML version of the keyword table. #17968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2014

Conversation

nodakai
Copy link
Contributor

@nodakai nodakai commented Oct 12, 2014

Really fix #17528.

Here is the resulting HTML output:

"Adjacent sibling selector" + was first introduced in CSS 2.1 and should be understood by many modern browsers.

@huonw
Copy link
Member

huonw commented Oct 12, 2014

It's possibly better to do this by inserting a (useless) thing just before the table, rather than relying on there being exactly one paragraph between the heading and the table, e.g.

<div id="keyword-table-marker"><!-- allow us to style the table specifically --></div>

|     |    | ...
|-----|...
...

and then the CSS would be #keyword-table-marker + table.

Also make some typographical changes.
@nodakai nodakai force-pushed the really-fix-kw-table branch from 72fcc99 to e2fed74 Compare October 12, 2014 10:38
@nodakai
Copy link
Contributor Author

nodakai commented Oct 12, 2014

@huonw I had some concern about possible side effects on PDF and ePUB outputs by Pandoc as I don't have Pandoc installed on my machine...

I'll use the paragraph saying "the following strings" itself as a marker because it almost guarantees the following element is the keyword table and I can expect less impact on Pandoc outputs than an empty DIV would do (if any.)

Let me also do piggybacking of some typographical changes. The result will look like this

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 13, 2014
@bors bors merged commit e2fed74 into rust-lang:master Oct 14, 2014
@nodakai nodakai deleted the really-fix-kw-table branch November 19, 2014 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyword table in the language reference is not rendered correctly
4 participants