Skip to content

Doc: Fixes small error in the task part #17986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2014
Merged

Conversation

gamazeps
Copy link
Contributor

The doc says that the type system catches error like trying to use a mutable variable used by another task, where it is the borrow checker taht does it (it seems far more logical)

@gamazeps gamazeps changed the title Fixes small error on the doc (task part) Doc: Fixes small error in the task part Oct 12, 2014
@gamazeps
Copy link
Contributor Author

r? @steveklabnik

@steveklabnik
Copy link
Member

The borrow checker isn't exactly part of the type system, but it kind of is. I'm not sure this distinction matters.

I'm on mobile, or I'd check myself: have we mentioned the 'borrow checker' anywhere yet in the guide this far?

@gamazeps
Copy link
Contributor Author

Yup we have already mentioned the borrow checker in the guide.

It seems to me that the distinction matters a lot, as the notion of borrowing has nothing to do with types (to my knowledge Rust is the only strongly typed language with notion of borrowing).
Beeing extremely precise on this notions seems rather important to me as it is a core concept of the language.

@steveklabnik
Copy link
Member

Lifetimes are kind of type parameters. It depends 😉

Anyway, this is not wrong, and we did explain it earlier, so seems good. Thanks!

@steveklabnik
Copy link
Member

Lifetimes are kind of type parameters. It depends 😉

Anyway, we did explain it earlier, so seems good. Thanks!

@gamazeps
Copy link
Contributor Author

@steveklabnik is @bors tired ? (I don't really know how he works :/ )

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 13, 2014
@steveklabnik
Copy link
Member

@gamazeps yeah, every once in a while the queue gets REALLY full. @alexcrichton is doing a rollup though, so this shouldget in soonish.

@bors bors merged commit 1cbce30 into rust-lang:master Oct 14, 2014
@gamazeps gamazeps deleted the docissue branch October 17, 2014 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants