Skip to content

debuginfo: Add timeout for LLDB tests. #18654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2014

Conversation

michaelwoerister
Copy link
Member

If a test takes longer than 10 seconds it will be aborted now, which should prevent the build infrastructure from being blocked for a full hour if an LLDB freeze happens.

Since, as far as I've seen, the freezing happens very rarely and at random tests, we could also get fancy and automatically retry running the tests a few times if it was aborted due to a timeout. That would be quite nice actually.

cc @alexcrichton

@alexcrichton
Copy link
Member

Are we sure that all tests should finish under 10s? That seems somewhat conservative, I'd be ok giving them all at least 5 minutes (it's better than an hour!) just in case the system is under high load.

@michaelwoerister
Copy link
Member Author

For testing I used 1s and all of them finished in time. But it's the exceptional case anyway, so 5 minutes should be fine too. Any thoughts regarding the automatic retrying? That would solve the problem completely, I guess.

@alexcrichton
Copy link
Member

I'm always somewhat wary of the auto-retry because it may end up accidentally pasting over real issues. For now let's see if we maybe get some extra debugging information if the process doesn't hang (and even prints something out!), and if it happens frequently we can implement the auto-retry.

Also if everything finished well under 1s then 10s is probably plenty. Maybe up it to 30 to be safe and call it a day?

@michaelwoerister
Copy link
Member Author

Maybe up it to 30 to be safe and call it a day?

Deal.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 6, 2014
@bors bors merged commit 36088ab into rust-lang:master Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants