Treat builtin bounds like all other kinds of trait matches. #18749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
builtin-bounds-like-other-traits
branch
from
7718b07 to
cdb303b
Compare
|
Nice 🎉 |
nikomatsakis
force-pushed
the
builtin-bounds-like-other-traits
branch
from
62ac290 to
112139f
Compare
nikomatsakis
force-pushed
the
builtin-bounds-like-other-traits
branch
from
112139f to
0f0d21c
Compare
|
This now needs rebased. |
… a simple hashset in the fulfillment context to catch cases where we register the exact same obligation twice. This helps prevent duplicate error reports but also handles the recursive obligations created by builtin bounds.
now don't print duplicate errors within one context, so I sometimes had to break functions into two functions.
…e code is nicer this way anyhow)
nikomatsakis
force-pushed
the
builtin-bounds-like-other-traits
branch
from
0f0d21c to
931758c
Compare
bors
added a commit
that referenced
this pull request
Dec 3, 2014
…aits, r=pcwalton Treat builtin bounds like all other kinds of trait matches. Introduce a simple hashset in the fulfillment context to catch cases where we register the exact same obligation twice. This helps prevent duplicate error reports but also handles the recursive obligations created by builtin bounds. r? @pcwalton cc @flaper87
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 7, 2025
…-wait minor: Break out of waiting for debugger on Windows using native debugger check API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat builtin bounds like all other kinds of trait matches. Introduce a simple hashset in the fulfillment context to catch cases where we register the exact same obligation twice. This helps prevent duplicate error reports but also handles the recursive obligations created by builtin bounds.
r? @pcwalton
cc @flaper87