Skip to content

Guide: Cleanup and proofread #18778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gamazeps
Copy link
Contributor

@gamazeps gamazeps commented Nov 8, 2014

First half for now

@gamazeps
Copy link
Contributor Author

gamazeps commented Nov 8, 2014

r? @steveklabnik

@@ -133,7 +133,8 @@ the documentation for your shell for more details.

Let's make a new source file next. I'm going to use the syntax `editor
filename` to represent editing a file in these examples, but you should use
whatever method you want. We'll call our file `main.rs`:
whatever method you want (if you are new to *nix try out emacs or vim investing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People may not know what "_nix" is, and it would be "_NIX" anyway ;)

Also, this isn't the place for vim or emacs promotion, and they would need graves around them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since talked a little about basic shell use before, I thought adding editor recommandations appropriate there (and I simply put vim and emacs as they are the most common)

@gamazeps gamazeps force-pushed the doc_cleanup branch 2 times, most recently from 4ee1fa6 to 2ae6384 Compare November 8, 2014 23:54
What about returning a value?

Rust functions return exactly one value, which type is declared after an arrow (a
dash (`-`) followed by a greater that sign (`>`)) in the function declaration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just writing it out as ->?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct :)

@gamazeps gamazeps force-pushed the doc_cleanup branch 3 times, most recently from 5d9aeeb to 5ef93ed Compare November 9, 2014 15:24
@gamazeps
Copy link
Contributor Author

gamazeps commented Nov 9, 2014

Done :)

@gamazeps
Copy link
Contributor Author

gamazeps commented Nov 9, 2014

r? @steveklabnik

@@ -133,7 +133,8 @@ the documentation for your shell for more details.

Let's make a new source file next. I'm going to use the syntax `editor
filename` to represent editing a file in these examples, but you should use
whatever method you want. We'll call our file `main.rs`:
whatever method you want (if you are new to *NIX try out emacs or vim investing
time in them really is useful). We'll call our file `main.rs`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still doing evangelism here. This change just isn't good, sorry :/

@quantheory
Copy link
Contributor

I've already commented to @steveklabnik about the punctuation around quotes, but it's relevant here, too.

Uncyclopedia mandates "logical" punctuation for everything, regardless of topic or English dialect. I took a look at the GNU Coding Standards, Python's PEPs, and the documentation for GHC; I don't know that any of those have explicitly have a standard, but all of those use logical punctuation in the first several examples I could find, despite otherwise preferring American English. I have trouble thinking of a major software project that mandates the traditional "American" punctuation.

Some American style guides (e.g. The Chicago Manual of Style) also recommend that periods should be placed outside quotations marks in cases where placing the period inside could change the meaning of the quoted text, such as for code snippets and file names.

So the point is, if Rust documentation requires commas/periods inside quotes, that won't really be "standard" American usage. Rather it will make Rust the odd man out in this respect.

@steveklabnik
Copy link
Member

@gamazeps this needs a rebase, and also has some unaddressed comments.

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to reopen with a rebase and comments addressed!

@gamazeps gamazeps deleted the doc_cleanup branch May 7, 2017 14:52
lnicola pushed a commit to lnicola/rust that referenced this pull request Jan 7, 2025
fix: Fix flycheck diagnostics flickering for binary targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants