you can't build unless you have git, so configure should require it #1887
Conversation
|
Thanks! There is one situation where we do build without git - distribution tarballs. If you look here the configure script is conditionalized to not use git if the source is not inside a git repo. Makefile.in does some similar checks. So to report this error we probably need to put it after we decide whether to set CFG_DISABLE_MANAGE_SUBMODULES, and only error if both CFG_DISABLE_MANAGE_SUBMODULES and CFG_GIT are not defined (or empty - not sure exactly). I merged the commit fixing the python quoting in the other pull request. |
|
@db48x Would you like to revise this pull request? |
|
Actually, I did make a change that I didn't actually commit anywhere... |
…, otherwise don't attempt to manage the submodules
|
I apologize for not merging this yet. I will do it tomorrow. |
|
Merged. Thanks. |
|
I did rebase this before committing it. |
I created a new template using the GitHub interface to see if that makes the template show up. I used a different name since the title reflects on the name of the file.
No description provided.