Add a function to copy from a Reader to a Writer #19012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. |
|
This looks like std::io::util::copy. |
|
D'oh! :) |
|
That one doesn't check for NoProgress though... shouldn't it? |
|
Not sure about that. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 27, 2025
feat: Implement `arbitrary-self-types`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move copying between streams from io::fs::copy() into a separate fn, adding a NoProgress check from read_at_least.
Initially I wanted to add a write_from_reader() to Writer but it seemed to run afoul of object safety rules.