remove grammar makefile rules #19282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
It calls the same stuff, which also does not work. |
|
It doesn't call the same stuff, |
|
Ugh. I got myself confused when messing with this. I see what you're saying now. I conflated two errors. |
steveklabnik
force-pushed
the
remove_grammar
branch
from
7117d1d to
ba9e02f
Compare
|
Updated. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 27, 2014
I stumbled across this today, and it's not really working. It's been around for a very, very long time, and seems to be based on stuff we don't even have anymore. I asked in `#rust-internals`, and @cmr said we should just kill it, so here I am. :) I don't think that anything else uses Java, but maybe I missed something. And if this _isn't_ what we want, I'm fine with closing too. Just some housekeeping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across this today, and it's not really working. It's been around for a very, very long time, and seems to be based on stuff we don't even have anymore.
I asked in
#rust-internals, and @cmr said we should just kill it, so here I am. :) I don't think that anything else uses Java, but maybe I missed something.And if this isn't what we want, I'm fine with closing too. Just some housekeeping.