Simplify RefCell code a bit, make deref a no-op.
#19386
Conversation
|
|
| #[unstable] | ||
| pub fn static_borrow_mut<'a>(&'a mut self) -> &'a mut T { | ||
| unsafe { &mut *self.value.get() } | ||
| } |
There was a problem hiding this comment.
For now could we hold off on the addition of new functions to the API? I'd help speed up getting through the internal refactoring.
There was a problem hiding this comment.
This is one of the best features of @chris-morgan's new mucell library, and I would really love it to be on RefCell too.
There was a problem hiding this comment.
This functionality can actually be on all types with internal mutability (including the atomic types and Cell), so I think these could/should be added in a global manner. And then that PR can have the discussion about APIs and naming, to speed this one through.
(I raised this on discuss a while ago so I guess that thread could be reused for the API discussion/bikeshedding.)
There was a problem hiding this comment.
@alexcrichton
Really sorry (!) for the inconvenience, I thought I removed all new functions, this was supposed to be a change in internals only. I fixed it
tbu-
force-pushed
the
pr_refcell_stuff
branch
from
15babac to
0021c92
Compare
tbu-
force-pushed
the
pr_refcell_stuff
branch
from
0021c92 to
5048953
Compare
|
I believe this failure wasn't caused by me. |
|
@alexcrichton Can you re-r+? This test failure appears in other pull requests too, e.g. in the "Implement |
|
@tbu- Yeah, this happens a lot. |
No description provided.