Print a friendly error for the if-let construct without an else block #20039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
|
Can you add a compile-fail test for the new error message? |
| ), | ||
| _ => ( | ||
| infer::MatchExpressionArm(expr.span, arm.body.span), | ||
| result_ty, // result_ty is "expected" here |
There was a problem hiding this comment.
I don't think you need this comment any more
There was a problem hiding this comment.
You mean the "expected"-related ones? I will remove them.
barosl
force-pushed
the
if-let-friendly-error
branch
8 times, most recently
from
d2d88c5 to
5ed3ab0
Compare
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
There was a problem hiding this comment.
Please add a comment saying what the test is testing.
|
Thanks for the fixes! Looks good, r=me with an extra comment in the test. |
barosl
force-pushed
the
if-let-friendly-error
branch
from
5ed3ab0 to
314ed2d
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 21, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2025
fix: Closure capturing for let exprs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19991.