Map EEXIST to PathAlreadyExists error, closes #20226 #20231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
In general I think we're going to carefully scrutinize |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 30, 2014
I've created a patch for rust-lang#20226, which maps `EEXIST` to the `PathAlreadyExists` error on Unix. To test this, I use `mkdir`, which raises `EEXIST` if the directory already exists. On Windows, I map `ERROR_ALREADY_EXISTS` to `PathAlreadyExist`, but I am note sure if `mkdir` on Windows raises `ERROR_ALREADY_EXISTS` and do not have a Windows installation handy for testing. And I noticed another thing. No error seems to map to `IoErrorKind::PathDoesntExist` and I am wondering what the difference to `FileNotFound` is?
|
Thanks! |
|
@Blei I was wondering what you used to discover this error? In the test case, I used |
|
mkdir was indeed how I discovered it. I guess you could grep manpages for Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a patch for #20226, which maps
EEXISTto thePathAlreadyExistserror on Unix. To test this, I usemkdir, which raisesEEXISTif the directory already exists.On Windows, I map
ERROR_ALREADY_EXISTStoPathAlreadyExist, but I am note sure ifmkdiron Windows raisesERROR_ALREADY_EXISTSand do not have a Windows installation handy for testing.And I noticed another thing. No error seems to map to
IoErrorKind::PathDoesntExistand I am wondering what the difference toFileNotFoundis?