Skip to content

Fix scoped thread local #20262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2014
Merged

Conversation

arturoc
Copy link
Contributor

@arturoc arturoc commented Dec 27, 2014

was missing a couple of semicolons and applications using it failed to compile

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@aturon
Copy link
Member

aturon commented Dec 27, 2014

Thanks for the PR!

Could I ask you to add a regression test that would catch this problem? (I'm actually surprised it wasn't previously caught -- @alexcrichton might know more).

@alexcrichton
Copy link
Member

Oddly enough it looks like the macro is a valid invocation when called inside of a function but not in an item scope! Not sure why this compiles in that case...

@arturoc
Copy link
Contributor Author

arturoc commented Dec 28, 2014

just added the regression tests for the case in an item scope but not sure how you can test the opposite case where the current version should be failing inside a function

@alexcrichton
Copy link
Member

Thanks! Could you also squash the commits together?

@arturoc arturoc force-pushed the fix-scoped_thread_local branch from de4025d to 156df26 Compare December 28, 2014 18:35
@arturoc arturoc force-pushed the fix-scoped_thread_local branch from 156df26 to 598866d Compare December 28, 2014 18:40
@arturoc arturoc force-pushed the fix-scoped_thread_local branch from 598866d to a454997 Compare December 28, 2014 18:43
@arturoc
Copy link
Contributor Author

arturoc commented Dec 28, 2014

just squashed them, hadn't done this in a while and have done a couple of pushes before getting it right which has messed this view. the repo is ok though, with one commit only.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2014
was missing a couple of semicolons and applications using it failed to compile
@bors bors merged commit a454997 into rust-lang:master Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants