Split left-shift into two less-than for properly parsing associated type syntax. #20409
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
The commit should be marked with |
|
This looks good. r+ with a comment plus a change to the commit to mention |
…ype syntax.
[breaking-change]
With this change any left-shift operator after an identifier such as
`as` will be incorrectly interpreted. To handle this you must change:
34 as uint << 3
To:
(34 as uint) << 3
|
Is this a dupe of #20154? |
|
Yes I think this was a dupe of #20154 (which is now merged), thanks regardless @kmcguire3413! |
No description provided.