-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Fix the parsing of where-clauses for tuple-structs #20424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0b1bf63
to
be684b5
Compare
We might want to make this parsing code less flexible and reject code like: |
I would personally prefer to reject where clauses in the old location entirely. |
I agree with @sfackler, we should not accept |
2ae38a9
to
58f19fd
Compare
Travis is unhappy /home/travis/build/rust-lang/rust/src/libsyntax/parse/parser.rs:4943: line longer than 100 chars |
r+ once tidy error is fixed |
5e971a8
to
a0495ed
Compare
a0495ed
to
fb1871d
Compare
A small test failure was lurking, rebased, fixed it and pushed again. |
Fixes rust-lang#17904. All the cases that I believe we should support are detailed in the test case, let me know if there is there is any more desired behavior. cc @japaric. r? @nikomatsakis or whoever is appropriate.
fb1871d
to
c02fac4
Compare
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this file doesn't pretty print correctly: alexcrichton@acef292
(it's fine to ignore pretty printing for now)
Fixes rust-lang#17904. All the cases that I believe we should support are detailed in the test case, let me know if there is there is any more desired behavior. cc @japaric. r? @nikomatsakis or whoever is appropriate.
Fixes #17904. All the cases that I believe we should support are detailed in the test case, let me know if there is there is any more desired behavior. cc @japaric.
r? @nikomatsakis or whoever is appropriate.