Skip to content

Make type in ast::Local optional #20425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2015
Merged

Make type in ast::Local optional #20425

merged 2 commits into from
Jan 2, 2015

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Jan 2, 2015

This avoids having ast::Ty nodes which have no counterpart in the source.

@eddyb
Copy link
Member

eddyb commented Jan 2, 2015

So this makes let x: _ = y; and let x = y; distinct? Could you check it with a pretty-print test?

@sanxiyn
Copy link
Member Author

sanxiyn commented Jan 2, 2015

Added a test.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 2, 2015
@alexcrichton
rollup merge of rust-lang#20425: sanxiyn/opt-local-ty
6f567e0 
This avoids having ast::Ty nodes which have no counterpart in the source.
@bors bors merged commit 4ae7c38 into rust-lang:master Jan 2, 2015
@sanxiyn sanxiyn deleted the opt-local-ty branch January 3, 2015 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanxiyn @eddyb @alexcrichton @bors