Skip to content

Fix pretty printers to work with the broader enum optimizations #20557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 7, 2015

Conversation

cactorium
Copy link
Contributor

As per #20405. To be more precise, the changes just the processing of enums when the name is "RUST$ENCODED$ENUM$..." so it correctly parses when there is more than one number encoding the location of the field it's looking for to determine state of the enum

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@huonw
Copy link
Member

huonw commented Jan 5, 2015

r? @michaelwoerister

@michaelwoerister
Copy link
Member

This looks very good to me at a first glance. Thanks for fixing those bugs!
Could you extend src/test/debuginfo/gdb-pretty-struct-and-enums.rs with a one or two test cases for this?

@cactorium
Copy link
Contributor Author

No problem, and done!

@michaelwoerister
Copy link
Member

Did you also run them? Because I'm pretty sure they should fail in the current form due to the wrong numbers in the gdb-check lines (should be $17 and $18). You can easily run them with make check-stage1-debuginfo-gdb.

@cactorium
Copy link
Contributor Author

Ah, my bad, I assumed that they were run manually since I couldn't figure out how testing could work off of comments. Tested and fixed!

@michaelwoerister
Copy link
Member

Looks great now, thanks a lot!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 7, 2015
As per rust-lang#20405. To be more precise, the changes just the processing of enums when the name is "RUST$ENCODED$ENUM$..." so it correctly parses when there is more than one number encoding the location of the field it's looking for to determine state of the enum
@alexcrichton alexcrichton merged commit d338572 into rust-lang:master Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants