debuginfo: Make debuginfo source location assignment more stable #20642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
|
r- until after the alpha release, will review then |
| pub fn expr_info(expr: &ast::Expr) -> NodeInfo { | ||
| NodeInfo { id: expr.id, span: expr.span } | ||
| impl NodeIdAndSpan { | ||
| pub fn to_source_location(&self) -> debuginfo::DebugLocation { |
There was a problem hiding this comment.
I'd prefer to_debug_location - source is ambiguous with spans
|
r=me, with the above addressed |
|
And this will also need a rebase |
michaelwoerister
force-pushed
the
sane-source-locations-pt1
branch
2 times, most recently
from
f4b1a27 to
e087c53
Compare
|
OK, I think I've addressed all Nick's issue. This should be good to go now. |
|
@michaelwoerister ping needs an update |
So far, the source location an LLVM instruction was linked to was controlled by `debuginfo::set_source_location()` and `debuginfo::clear_source_location()`. This interface mimicked how LLVM's `IRBuilder` handles debug location assignment. While this interface has some theoretical performance benefits, it also makes things terribly unstable: One sets some quasi-global state and then hopes that it is still correct when a given instruction is emitted---an assumption that has been proven to not hold a bit too often. This patch requires the debug source location to be passed to the actual instruction emitting function. This makes source location assignment explicit and will prevent future changes to `trans` from accidentally breaking things in the majority of cases. This patch does not yet implement the new principle for all instruction kinds but the stepping experience should have improved significantly nonetheless already.
michaelwoerister
force-pushed
the
sane-source-locations-pt1
branch
from
e087c53 to
a55ef3a
Compare
|
@nick29581: rebased |
|
⌛ Testing commit a55ef3a with merge 3a053ac... |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 21, 2015
…ns-pt1 Conflicts: src/librustc_trans/trans/debuginfo.rs
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry |
|
⌛ Testing commit a55ef3a with merge 080d476... |
|
Trying to kick bors... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the source location an LLVM instruction was linked to was controlled by
debuginfo::set_source_location()anddebuginfo::clear_source_location(). This interface mimicked how LLVM'sIRBuilderhandles debug location assignment. While this interface has some theoretical performance benefits, it also makes things terribly unstable: One sets some quasi-global state and then hopes that it is still correct when a given instruction is emitted---an assumption that has been proven to not hold a bit too often.This patch requires the debug source location to be passed to the actual instruction emitting function. This makes source location assignment explicit and will prevent future changes to
transfrom accidentally breaking things in the majority of cases.This patch does not yet implement the new principle for all instruction kinds but the stepping experience should have improved significantly nonetheless already.
🐔 🐤 🐤 🐤