std: Mark two missing functions as #[stable] #20839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `Extend::extend` and `DoubleEndedIterator::next_back` were intended to be stable, but they mistakenly didn't have the `#[stable]` tag.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Jan 10, 2015
Both `Extend::extend` and `DoubleEndedIterator::next_back` were intended to be stable, but they mistakenly didn't have the `#[stable]` tag.
|
Vec and String are missing stable on their Extend impls too. |
|
I think the intention was that the trait's listed stability is inherited by implementations. I think this change was made to rustc, but not to rustdoc. Regardless though, I'll test this once it hits nightlies just to make sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
Extend::extendandDoubleEndedIterator::next_backwere intended to bestable, but they mistakenly didn't have the
#[stable]tag.