Updates fixed-size suffix in 30 minute introduction #20895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler gives the following warning: `warning: the `u` suffix on integers is deprecated; use `us` or one of the fixed-sized suffixes` And also the errror: `error: mismatched types: expected `u64`, found `usize` (expected u64, found usize)` Changing the suffix to `u64` results in a successful `cargo run` outputting the desired `Versions compared successfully!`
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
This is a pull request to update the documentation on the rust-lang site. |
|
Thank you! This also fixes #20967 |
bors
added a commit
that referenced
this pull request
Jan 12, 2015
Updates fixed-size suffix in 30 minute introduction Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler gives the following warning:
warning: theusuffix on integers is deprecated; useusor one of the fixed-sized suffixesAnd also the errror:
error: mismatched types: expectedu64, foundusize(expected u64, found usize)Changing the suffix to
u64results in a successfulcargo runoutputting the desiredVersions compared successfully!