Skip to content

Ease parsing of an English sentence #20929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2015
Merged

Conversation

laurilehmijoki
Copy link

The sentence is easier to read once we move the word "again" away from the last position.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@Gankra Gankra assigned steveklabnik and unassigned brson Jan 11, 2015
@Gankra
Copy link
Contributor

Gankra commented Jan 11, 2015

As a native speaker, I suck at English, but I personally would go for "let's look again...". Tossing this to @steveklabnik because they know how to words gooder than I.

@stevencrockett
Copy link
Contributor

I agree that using again at the end is a bit trickier to parse.

That said, I'd go for something like:
"Let's look back at the previous function which..." or "Recall the previous function which..."

@steveklabnik
Copy link
Member

I find the new version much harder to read. How about

Remember the function that did x? Let's look at it again.

@laurilehmijoki
Copy link
Author

I just rephrased the sentence according to the suggestion by @steveklabnik.

@steveklabnik
Copy link
Member

This says it's out of date, so we might need a rebase here.

@laurilehmijoki
Copy link
Author

I just solved the merge conflict.

bors added a commit that referenced this pull request Jan 14, 2015
Ease parsing of an English sentence

Reviewed-by: steveklabnik, steveklabnik
bors added a commit that referenced this pull request Jan 14, 2015
Ease parsing of an English sentence

Reviewed-by: steveklabnik, steveklabnik
bors added a commit that referenced this pull request Jan 15, 2015
Ease parsing of an English sentence

Reviewed-by: steveklabnik, steveklabnik
bors added a commit that referenced this pull request Jan 15, 2015
Ease parsing of an English sentence

Reviewed-by: steveklabnik, steveklabnik
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 15, 2015
The sentence is easier to read once we move the word "again" away from the last position.
@bors bors merged commit eabf208 into rust-lang:master Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants