-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Ease parsing of an English sentence #20929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
As a native speaker, I suck at English, but I personally would go for "let's look again...". Tossing this to @steveklabnik because they know how to words gooder than I. |
I agree that using again at the end is a bit trickier to parse. That said, I'd go for something like: |
I find the new version much harder to read. How about
|
55c0d8d
to
13899aa
Compare
I just rephrased the sentence according to the suggestion by @steveklabnik. |
13899aa
to
196d6f3
Compare
This says it's out of date, so we might need a rebase here. |
196d6f3
to
eabf208
Compare
I just solved the merge conflict. |
Ease parsing of an English sentence Reviewed-by: steveklabnik, steveklabnik
Ease parsing of an English sentence Reviewed-by: steveklabnik, steveklabnik
Ease parsing of an English sentence Reviewed-by: steveklabnik, steveklabnik
Ease parsing of an English sentence Reviewed-by: steveklabnik, steveklabnik
The sentence is easier to read once we move the word "again" away from the last position.
The sentence is easier to read once we move the word "again" away from the last position.