Refactor asserts, remove rust_srv #2102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is gorgeous. |
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
fix conflicting link names that lead to the "chapter link" leading to rustdoc's source code instead.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
fix conflicting link names that lead to the "chapter link" leading to rustdoc's source code instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2077 - remove the assertion macroas and favor just assert(condition && "msg");
Also, the second commit completely removes rust_srv from rt. Instead, memory regions are kept in rust_sched_loop and rust_env's are passed around. There are a few fprintf's about now, though.