implement ExactSizeIterator for slice::{Chunks,ChunksMut,Windows}
#21053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -1212,6 +1212,9 @@ impl<'a, T> Iterator for Windows<'a, T> { | |||
| } | |||
| } | |||
|
|
|||
| #[stable] | |||
| impl<'a, T> ExactSizeIterator for Windows<'a, T> {} | |||
There was a problem hiding this comment.
This implementation may not forever be right as the above size_hint may sometimes return None for the upper bound (albeit somewhat rarely)
There was a problem hiding this comment.
I assume I should remove this impl, then?
There was a problem hiding this comment.
For now, yes, let's remove it until we're guaranteed that size_hint always returns an exact size hint.
|
Thanks! Could you add some tests for the new implementations as well? |
|
Updated. |
|
@bors: r+ 1a76263 Thanks! |
|
I had to update this due to missing imports and a mutability issue in the tests. |
|
@bors: rollup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.