[r+] coherence: Allow impls of builtin traits just on structs/enums #21167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaper87
force-pushed
the
coherence-impls
branch
3 times, most recently
from
2a0244a to
41d0413
Compare
| self.tcx.sess.span_err( | ||
| item.span, | ||
| &format!("builtin traits can only be \ | ||
| implemented on `structs` or `enums`")[]); |
There was a problem hiding this comment.
I think we can remove the "`" quotes here
flaper87
force-pushed
the
coherence-impls
branch
from
41d0413 to
de7b3cf
Compare
nikomatsakis
changed the title
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 15, 2015
Fixes rust-lang#21080 r? @nikomatsakis [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21080
r? @nikomatsakis
[breaking-change]