Make date of nightly in rustup match server TZ #21274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Nightly builds take ~4-5 hours. |
|
@estsauver We talked about this at the workshop today, and although the ideal solution would be to have the metadata available for rustup to know the most recent archive date, we agreed on an offset that would hopefully work around the worst of the problem. Is this PR updated for that offset? Do you mind adding a |
|
Updated now. |
|
@bors: rollup |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 21, 2015
The timezone of the server that builds rustc nightlies appears to be in UTC. From what I can tell, it builds the nightlies at 0300 UTC, which takes about ~15 minutes. So, there were a couple options here for which offset to use. UTC+3 would ensure that you always got the latest rust, but it would mean the script is broken ~15/20 minutes a day. UTC+4 means users get a stale nightly for 45 minutes, but that feels okay to me. Ideally, buildbot would publish the "current" nightly, but that seems unneeded relative to fixing it for all Timezones quickly. Fixes rust-lang#21270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timezone of the server that builds rustc nightlies
appears to be in UTC. From what I can tell, it builds
the nightlies at 0300 UTC, which takes about ~15 minutes.
So, there were a couple options here for which offset to use.
UTC+3 would ensure that you always got the latest rust, but it
would mean the script is broken ~15/20 minutes a day. UTC+4
means users get a stale nightly for 45 minutes, but that feels
okay to me.
Ideally, buildbot would publish the "current" nightly, but
that seems unneeded relative to fixing it for all Timezones
quickly.
Fixes #21270