Skip to content

Add example for Lifetime Elision with two inputs. #21285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

snowe2010
Copy link
Contributor

Lifetime elision with two input references is not clear.
Closes #21284

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@huonw
Copy link
Member

huonw commented Jan 17, 2015

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned huonw Jan 17, 2015
@steveklabnik
Copy link
Member

This is now out of date, and needs a rebase.

@snowe2010
Copy link
Contributor Author

I was waiting for input on my comment. What should I change the question mark to?

@Gankra
Copy link
Contributor

Gankra commented Jan 22, 2015

I think just leaving the questionmark off should be sufficient in context.

That is, just -> &str

@snowe2010
Copy link
Contributor Author

r=steveklabnik I think it's ready, let me know if I need to clean anything up. Also, not sure if I did the r= bit right.

@steveklabnik
Copy link
Member

You can't add the r, only people with permission can :)

I think the rebase went wrong here, there's a tooon of unrelated commits.

@snowe2010
Copy link
Contributor Author

I'm not seeing any unrelated commits? Where exactly do you see them?

@Gankra
Copy link
Contributor

Gankra commented Jan 24, 2015

screenshot from 2015-01-24 01 53 41

@snowe2010
Copy link
Contributor Author

@gankro, those were there before I rebased. I saw them show up like 2 days before I rebased. I didn't do any of that. You can check from my commit history on my repo too. Don't know how those got there.

@snowe2010
Copy link
Contributor Author

This has been moved to #21618 due to (maybe) Github problems and the fact that this PR somehow won't update anymore from my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Ownership guide does not clearly explain what happens when there are two or more elided lifetimes
5 participants