Tell the compiler to tell us that deriving is dead.
#21605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
huonw
force-pushed
the
omg-muscle-memory
branch
from
fb26361 to
935082a
Compare
| span: Span, | ||
| mitem: &MetaItem, | ||
| item: &Item, | ||
| mut push: Box<FnMut(P<Item>)>) { |
There was a problem hiding this comment.
These will trigger unused argument warnings.
I'm beginning to suspect it's impossible to avoid accidentally writing `#[deriving]` at least once in every program, and it results in non-intuitive error messages: "Foo doesn't have any method in scope `clone`" despite there being a `#[deriv...(Clone)]` attribute! Also, lots of documentation around the internet uses `#[deriving]` so providing this guidance is very helpful (lots of people ask in #rust about this error). Fixes rust-lang#21166.
huonw
force-pushed
the
omg-muscle-memory
branch
from
935082a to
ae4e1a1
Compare
bors
added a commit
that referenced
this pull request
Jan 26, 2015
I'm beginning to suspect it's impossible to avoid accidentally writing `#[deriving]` at least once in every program, and it results in non-intuitive error messages: "Foo doesn't have any method in scope `clone`" despite there being a `#[deriv...(Clone)]` attribute! Also, lots of documentation around the internet uses `#[deriving]` so providing this guidance is very helpful (lots of people ask in #rust about this error).
|
👀 Test was successful, but fast-forwarding failed |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jan 26, 2015
I'm beginning to suspect it's impossible to avoid accidentally writing `#[deriving]` at least once in every program, and it results in non-intuitive error messages: "Foo doesn't have any method in scope `clone`" despite there being a `#[deriv...(Clone)]` attribute! Also, lots of documentation around the internet uses `#[deriving]` so providing this guidance is very helpful (lots of people ask in #rust about this error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm beginning to suspect it's impossible to avoid accidentally writing
#[deriving]at least once in every program, and it results innon-intuitive error messages: "Foo doesn't have any method in scope
clone" despite there being a#[deriv...(Clone)]attribute!Also, lots of documentation around the internet uses
#[deriving]soproviding this guidance is very helpful (lots of people ask in #rust
about this error).