add split_off method to vec with tests #21608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @gankro |
| /// Splits the collection into two at the given index. | ||
| /// | ||
| /// Returns a newly allocated `Self`. `self` contains elements `[0..at]`, | ||
| /// and the returned `Self` contains elements `[at ..]`. |
There was a problem hiding this comment.
I'm a bit nervosd about this since this is accurate Rust notation, but confusing as math notation.
probably fine as is, though.
|
@gankro I've made all the changes required by the comments, please review. I'll squash my commits down if it looks good. |
|
r=me with assert message and squash |
|
I was going off the (lack of) message in slice.split_at |
JeffBelgum
force-pushed
the
collections-reform-issue-19986-add-append-and-split-off
branch
from
8696e9a to
b93843e
Compare
|
r? @gankro |
|
@bors r+ b938 rollup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brson @gankro