Skip to content

wrmdir -> RemoveDirectoryW #21640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2015
Merged

wrmdir -> RemoveDirectoryW #21640

merged 1 commit into from
Jan 29, 2015

Conversation

retep998
Copy link
Member

_wrmdir is literally just a wrapper around RemoveDirectoryW, so let's just use RemoveDirectoryW.
r? @alexcrichton

Signed-off-by: Peter Atashian <[email protected]>
@alexcrichton
Copy link
Member

@bors: r+ 8f38eae rollup

@nagisa
Copy link
Member

nagisa commented Jan 26, 2015

Do we want to keep wrmdir in liblibc since it is not used anymore?

@retep998
Copy link
Member Author

@nagisa The goal is to eventually replace all usages of posix and libc functions with the relevant win32 functions. Since there is now a libc on crates.io we should get rid of anything we don't use from Rust's libc.

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015
`_wrmdir` is literally just a wrapper around `RemoveDirectoryW`, so let's just use `RemoveDirectoryW`.
r? @alexcrichton
Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 28, 2015
`_wrmdir` is literally just a wrapper around `RemoveDirectoryW`, so let's just use `RemoveDirectoryW`.
r? @alexcrichton
@bors bors merged commit 8f38eae into rust-lang:master Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants