Add on_unimplemented note to Index #21658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ 2b4d2 rollup |
Manishearth
force-pushed
the
index_on_unimplemented
branch
from
2b4d2ea to
8f922a1
Compare
|
@bors r+ 8f922 rollup |
Manishearth
force-pushed
the
index_on_unimplemented
branch
from
8f922a1 to
ef5a06f
Compare
|
@bors r+ ef5a06f rollup |
|
FOR REALS THIS TIME |
| @@ -895,6 +895,7 @@ shr_impl_all! { u8 u16 u32 u64 usize i8 i16 i32 i64 isize } | |||
| /// } | |||
| /// ``` | |||
| #[lang="index"] | |||
| #[rustc_on_unimplemented = "the type {Self} cannot be indexed by {Index}"] | |||
There was a problem hiding this comment.
Hmm, there should probably be backticks around {Self} and {Index} here.
Manishearth
force-pushed
the
index_on_unimplemented
branch
from
ef5a06f to
6a90eca
Compare
|
@gankro Okay, perhaps not for reals? :> Need another r+ :p |
|
What changed? |
|
Backticks were added. |
|
@bors r+ 6a90 rollup |
barosl
added a commit
to barosl/rust
that referenced
this pull request
Jan 27, 2015
… r=Gankro Helps issues like [these](http://www.reddit.com/r/rust/comments/2tpefm/unable_to_access_array_elements/) r? @gankro rollup-worthy
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jan 27, 2015
… r=Gankro Helps issues like [these](http://www.reddit.com/r/rust/comments/2tpefm/unable_to_access_array_elements/) r? @gankro rollup-worthy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps issues like these
r? @gankro
rollup-worthy