cleanup: s/v.slice*()/&v[a..b]/g + remove redundant as_slice() calls
#21680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ 02dd786 <3 this cleanup |
| @@ -155,7 +155,7 @@ impl<'a> Iterator for MutDnaSeqs<'a> { | |||
| fn next(&mut self) -> Option<&'a mut [u8]> { | |||
| let tmp = std::mem::replace(&mut self.s, &mut []); | |||
| let tmp = match memchr(tmp, b'\n') { | |||
| Some(i) => tmp.slice_from_mut(i + 1), | |||
| Some(i) => &mut tmp[i + 1..], | |||
There was a problem hiding this comment.
Is this equivalent to (i+1)..? Seems a bit surprising given how .. looks like it's attached to 1.
There was a problem hiding this comment.
yes, and yes. I think some people tend to write i+1.. (no spaces), to improve readability, but I think we don't have a convention for this (yet).
bors
added a commit
that referenced
this pull request
Jan 27, 2015
Replaces `slice_*` method calls with slicing syntax, and removes `as_slice()` calls that are redundant due to `Deref`.
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
|
⌛ Testing commit bce81e2 with merge 7152b50... |
|
💔 Test failed - auto-linux-32-nopt-t |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jan 29, 2015
Replaces `slice_*` method calls with slicing syntax, and removes `as_slice()` calls that are redundant due to `Deref`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
slice_*method calls with slicing syntax, and removesas_slice()calls that are redundant due toDeref.