-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Pull configs out into individual repositories #21738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
As we grow, these don't belong in-tree. http://internals.rust-lang.org/t/moving-editor-highlighting-into-their-own-repos/1395 * https://github.com/rust-lang/rust.vim * https://github.com/rust-lang/rust-mode * https://github.com/rust-lang/gedit-config * https://github.com/rust-lang/kate-config * https://github.com/rust-lang/nano-config * https://github.com/rust-lang/zsh-config
e50c3e7
to
017b3a5
Compare
Are they still installed though? |
@tbu-: what do you mean, are they installed? If you mean what I think you mean, that’d be the job of packagers, not us (as it always has been, hasn’t it?). |
@chris-morgan We're implicitely packagers too, with rustup.sh for example. |
@tbu-: rustup.sh works from the nightly builds, which don’t include these things. |
@chris-morgan We're packagers – not packaging things that were previously installed is a usability loss. If this becomes impossible to support once the editor files are moved out of the main repo, maybe that should be reconsidered instead? |
Lurking in, this seems like it's a going to devolve into bikeshedding pretty fast. However, in general the convention tends to be that:
In general though, moving them to a place that is more easily discovered should generally be considered a usability win, imo. As a trivial example, if you don't want to install your rusts system wide, you now have the option to install the editor plugins system wide, or to install them separately and not have your editor config depend on the arbitrary place you install rust to. my 2c, and I apologise in advance if this just makes the bikeshedding worse. |
@tbu-: I’m saying that I don’t believe we ever did install these things. |
As far as the Vim files are concerned, I intend to submit it upstream (into the Vim and Syntastic repositories) when Rust 1.0 is released. |
As we grow, these don't belong in-tree. http://internals.rust-lang.org/t/moving-editor-highlighting-into-their-own-repos/1395 * https://github.com/rust-lang/rust.vim * https://github.com/rust-lang/rust-mode * https://github.com/rust-lang/gedit-config * https://github.com/rust-lang/kate-config * https://github.com/rust-lang/nano-config * https://github.com/rust-lang/zsh-config
As we grow, these don't belong in-tree.
http://internals.rust-lang.org/t/moving-editor-highlighting-into-their-own-repos/1395