Skip to content

Pull configs out into individual repositories #21738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2015

Conversation

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 017b3a5 rollup

@tbu-
Copy link
Contributor

tbu- commented Jan 29, 2015

Are they still installed though?

@chris-morgan
Copy link
Member

@tbu-: what do you mean, are they installed? If you mean what I think you mean, that’d be the job of packagers, not us (as it always has been, hasn’t it?).

@tbu-
Copy link
Contributor

tbu- commented Jan 30, 2015

@chris-morgan We're implicitely packagers too, with rustup.sh for example.

@chris-morgan
Copy link
Member

@tbu-: rustup.sh works from the nightly builds, which don’t include these things.

@tbu-
Copy link
Contributor

tbu- commented Jan 30, 2015

@chris-morgan We're packagers – not packaging things that were previously installed is a usability loss. If this becomes impossible to support once the editor files are moved out of the main repo, maybe that should be reconsidered instead?

@richo
Copy link
Contributor

richo commented Jan 30, 2015

Lurking in, this seems like it's a going to devolve into bikeshedding pretty fast. However, in general the convention tends to be that:

  • Editors ship a set of sane defaults in core. As rust grows adoption, I would expect vim/emacs/nano and pals to do something reasonable about syntax highlighting etc out of the box.
  • Users are increasingly managing their own editor configs out of tree anyway. For this usecase, bundling them separately is a huge usability win.

In general though, moving them to a place that is more easily discovered should generally be considered a usability win, imo. As a trivial example, if you don't want to install your rusts system wide, you now have the option to install the editor plugins system wide, or to install them separately and not have your editor config depend on the arbitrary place you install rust to.

my 2c, and I apologise in advance if this just makes the bikeshedding worse.

@chris-morgan
Copy link
Member

@tbu-: I’m saying that I don’t believe we ever did install these things.

@chris-morgan
Copy link
Member

As far as the Vim files are concerned, I intend to submit it upstream (into the Vim and Syntastic repositories) when Rust 1.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants