-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Remove weird Cell example from InvariantType docs #21828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Hi there! Thanks for the PR. Everything looks in order, but I'm not sure this example deserves to be removed. |
Woops, I'm sorry, I probably should've asked around a little before making the changes. |
I don't know much about |
This avoids triggering #21694. It probably is a better way to do it anyway.
@leejunseok some odd commits have crept in here, can you rebase and sqaush? r=me after |
hrm, sorry git still isn't quite natural to me, I'm trying to get my history sorted out. |
I didn't know how to sync rust-lang/rust and my own rust (along with my local repo) and I ended up doing something very strange to my repo. I've figured it out now, but my history was too mangled for me to save. I'll open another PR! Sorry about the inconvenience! |
Should fix #20147
P.S. This is my first PR in the history of ever. Please let me know if I'm doing anything wrong.