Order list of files linted in tidy.py by frequency #22029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added another commit that refactors Edit: Squashed the commit that removed the wildcard import into 9569691. |
Since it makes more sense for .rs files to appear at the top of the list of linted files and "other" files to appear at the end, this commit moves the "other" count outside of the `file_counts` dictionary and sorts the remaining "interesting" files by decreasing frequency.
- Replace wildcard import with explicit import of `check_license` - Move more logic outside of the `try` block. - Group all helper functions together. - Define `interesting_exts` and `uninteresting_files` at start of file (with the rest of the constant declarations).
|
@bors: rollup r+ Sorry for missing this for so long. |
|
@brson No worries; glad it could be merged in! |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 4, 2015
Currently, the list of files linted in `tidy.py` is unordered. It seems more appropriate for more frequently appearing files (like `.rs`) to appear at the top of the list and for \"other files\" to appear at the very end. This PR also changes the wildcard import of `check_license()` into an explicit one. ``` Before: After: * linted 4 .sh files * linted 5034 .rs files * linted 4 .h files * linted 29 .c files * linted 29 .c files * linted 28 .py files * linted 2 .js files * linted 4 .sh files * linted 0 other files * linted 4 .h files * linted 28 .py files * linted 2 .js files * linted 5034 .rs files * linted 0 other files ``` r? @brson
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 5, 2015
Currently, the list of files linted in `tidy.py` is unordered. It seems more appropriate for more frequently appearing files (like `.rs`) to appear at the top of the list and for \"other files\" to appear at the very end. This PR also changes the wildcard import of `check_license()` into an explicit one. ``` Before: After: * linted 4 .sh files * linted 5034 .rs files * linted 4 .h files * linted 29 .c files * linted 29 .c files * linted 28 .py files * linted 2 .js files * linted 4 .sh files * linted 0 other files * linted 4 .h files * linted 28 .py files * linted 2 .js files * linted 5034 .rs files * linted 0 other files ``` r? @brson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the list of files linted in
tidy.pyis unordered. It seems more appropriate for more frequently appearing files (like.rs) to appear at the top of the list and for "other files" to appear at the very end. This PR also changes the wildcard import ofcheck_license()into an explicit one.r? @brson