Skip to content

rustc: Do not link to plugins #22197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2015
Merged

Conversation

alexcrichton
Copy link
Member

This flag seems to have erroneously been set to true.

This flag seems to have erroneously been set to `true`.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @kmcallister

@kmcallister
Copy link
Contributor

@bors r+ d4cece2 rollup

Nice catch, I missed that in my branch. I should figure out why the tests didn't catch it. Perhaps a run-make test which actually checks the set of linked libraries / symbols is in order.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 12, 2015
@sfackler
Copy link
Member

I believe the linker won't actually link to libraries that are never referenced, which could be why the tests never caught it.

@bors bors merged commit d4cece2 into rust-lang:master Feb 12, 2015
@alexcrichton alexcrichton deleted the do-not-link-plugins branch February 12, 2015 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants