unicode: Properly parse ranges in UnicodeData.txt #23000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the ranges contained in UnicodeData.txt. Counterintuitively this actually makes the tables shorter.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Since this changes the tables I assume it alters the behavior of some string APIs. Can you add a test that captures what was broken here? |
|
You'd think, but except for two tables (that are unaffected by this change) all of these exist just for the benefit of the regexp crate right now. |
|
@bors: rollup r+ OK, taking this on blind faith! |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 4, 2015
This handles the ranges contained in UnicodeData.txt. Counterintuitively this actually makes the tables shorter.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 5, 2015
This handles the ranges contained in UnicodeData.txt. Counterintuitively this actually makes the tables shorter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the ranges contained in UnicodeData.txt.
Counterintuitively this actually makes the tables shorter.