Skip to content

Introduction concurrent examples aren't actually concurrent #23202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2015

Conversation

shepmaster
Copy link
Member

If we end the scoped call with a semicolon, the JoinGuard will be
dropped and not returned from the map. The thread will start up and
we immediately block, making for a very expensive sequential loop.

If we end the `scoped` call with a semicolon, the `JoinGuard` will be
dropped and not returned from the `map`. The thread will start up and
we immediately block, making for a very expensive sequential loop.
@shepmaster
Copy link
Member Author

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Mar 8, 2015
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

@bors: r+ b426a24 Rollup

@steveklabnik
Copy link
Member

@bors: rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 9, 2015
…rent, r=steveklabnik

 If we end the `scoped` call with a semicolon, the `JoinGuard` will be
dropped and not returned from the `map`. The thread will start up and
we immediately block, making for a very expensive sequential loop.
@bors bors merged commit b426a24 into rust-lang:master Mar 9, 2015
@shepmaster shepmaster deleted the intro-threads-not-concurrent branch March 9, 2015 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants