Skip to content

Rename two instances of MAP_NONRESERVE #23409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2015
Merged

Rename two instances of MAP_NONRESERVE #23409

merged 1 commit into from
Mar 17, 2015

Conversation

strega-nil
Copy link
Contributor

To the correct MAP_NORESERVE. Every other instance is known as MAP_NORESERVE, so this is just a basic typo.

I really doubt this will break anybody's but my own code.

[breaking-change]

To the correct MAP_NORESERVE. Every other thing is known as MAP_NORESERVE, so this is just a basic typo.

I really doubt this will break anybody's but my own code.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@strega-nil
Copy link
Contributor Author

Actually, now that I look, there is no one actually using this, except for some documentation and some libraries that will be updated (and me). So... technically [BREAKING], but not really.

@alexcrichton alexcrichton changed the title [BREAKING] Rename two instances of MAP_NONRESERVE Rename two instances of MAP_NONRESERVE Mar 16, 2015
@alexcrichton
Copy link
Member

@bors: r+

Thanks! We actually have a breaking changes policy for how to denote a breaking change or not (I went ahead and edited this description and title).

@bors
Copy link
Collaborator

bors commented Mar 16, 2015

@bors r=alexcrichton cbd37d8

@oli-obk
Copy link
Contributor

oli-obk commented Mar 16, 2015

this closes #23408

@GuillaumeGomez
Copy link
Member

I close mine too (#23413).

@strega-nil
Copy link
Contributor Author

@alexcrichton Thanks :)

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 17, 2015
 To the correct MAP_NORESERVE. Every other instance is known as MAP_NORESERVE, so this is just a basic typo.

I really doubt this will break anybody's but my own code.

[breaking-change]
@bors bors merged commit cbd37d8 into rust-lang:master Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants