core: Inline most cell methods. #23495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a significant performance problem in Servo.
|
Is LLVM really not inlining these functions? The bodies are miniscule, and the'll get monomorphized in the other crate. I wonder if we need to tune our inline cost. |
|
@cmr No, they do not all get monomorphized. Many of them just have lifetime parameters and so are not automatically monomorphized. This patch is based on actual profiling I did in Servo. |
|
@cmr In particular |
|
@bors: r+ rollup |
|
📌 Commit 5f0f2aa has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 19, 2015
This is a significant performance problem in Servo. r? @brson
|
This merged, 19b40f7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant performance problem in Servo.
r? @brson