Skip to content

Socket options #23517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2015
Merged

Socket options #23517

merged 2 commits into from
Mar 24, 2015

Conversation

vhbit
Copy link
Contributor

@vhbit vhbit commented Mar 19, 2015

Continuation of #23380 - added corresponding constants for Windows, Linux, *BSDs

r? @alexcrichton

Alex, can you also cc to a person who can check correctness for Windows as I'm not that confident in header file I've downloaded.

drewcrawford and others added 2 commits March 19, 2015 16:04
… options.

This is probably more broadly applicable than these two platforms
(since it's part of the bsd4.4 standard) but that's outside my problem domain today.
If this goes well, I may submit Linux/64 support in a separate PR.

Reviewers should take a look at http://www.opensource.apple.com/source/xnu/xnu-792.17.14/bsd/sys/socket.h?txt
which defines constants for OSX.  iOS uses the same header.

I release this patch under the MIT license.
@alexcrichton
Copy link
Member

@bors: r+

Thanks! (verified windows/osx/linux)

@bors
Copy link
Collaborator

bors commented Mar 20, 2015

📌 Commit 6f09dfc has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

⌛ Testing commit 6f09dfc with merge 01cd643...

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

💔 Test failed - auto-linux-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Mar 20, 2015 at 10:25 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-32-nopt-t
http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4144


Reply to this email directly or view it on GitHub
#23517 (comment).

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

⌛ Testing commit 6f09dfc with merge 4db242f...

bors added a commit that referenced this pull request Mar 21, 2015
Continuation of #23380 - added corresponding constants for Windows, Linux, *BSDs

r? @alexcrichton 

Alex, can you also cc to a person who can check correctness for Windows as I'm not that confident in header file I've downloaded.
@bors
Copy link
Collaborator

bors commented Mar 21, 2015

💔 Test failed - auto-win-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

@brson
Copy link
Contributor

brson commented Mar 21, 2015

@bors force

@brson
Copy link
Contributor

brson commented Mar 21, 2015

@bors: force

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Mar 21, 2015 at 3:59 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4179


Reply to this email directly or view it on GitHub
#23517 (comment).

@bors
Copy link
Collaborator

bors commented Mar 22, 2015

⌛ Testing commit 6f09dfc with merge 80d8538...

@bors
Copy link
Collaborator

bors commented Mar 22, 2015

💔 Test failed - auto-mac-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Mar 22, 2015 at 3:50 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4189


Reply to this email directly or view it on GitHub
#23517 (comment).

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2015
Continuation of rust-lang#23380 - added corresponding constants for Windows, Linux, *BSDs

r? @alexcrichton

Alex, can you also cc to a person who can check correctness for Windows as I'm not that confident in header file I've downloaded.
@bors bors merged commit 6f09dfc into rust-lang:master Mar 24, 2015
@vhbit vhbit deleted the ext-socket-options branch April 3, 2015 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants